fix: pull the chromium version from the binary, not the monorepo when testing the packaged app COMPASS-9421 #7108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the packaged app
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new CLI flag --versions to print the full process.versions JSON (Node, Electron, Chromium) and updates the end-to-end test setup to dynamically derive the Chromium version from the target Electron binary (packaged or monorepo) to avoid mismatches.
- Add
--versionsflag in the Compass main process to output all process versions. - Extend preferences schema to include a
versionsboolean flag. - Rename test-runner constants to
MONOREPO_ELECTRON_*and implementgetChromiumVersionFromBinaryfor packaged-app tests. - Update E2E helpers (
compass.tsandcompass-web-sandbox.ts) to use the correct Chromium version depending on context.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/compass/src/main/index.ts | Added --versions CLI check to dump process.versions. |
| packages/compass-preferences-model/src/preferences-schema.tsx | Added versions preference and schema entry for the new flag. |
| packages/compass-e2e-tests/helpers/test-runner-paths.ts | Renamed Electron version exports to distinguish monorepo. |
| packages/compass-e2e-tests/helpers/compass.ts | Imported new monorepo constant, added getChromiumVersionFromBinary, and conditional version logic. |
| packages/compass-e2e-tests/helpers/compass-web-sandbox.ts | Switched to use MONOREPO_ELECTRON_CHROMIUM_VERSION import. |
Comments suppressed due to low confidence (2)
packages/compass/src/main/index.ts:60
- The new --versions flag isn't mentioned in the CLI help output; consider updating
getHelpText()or the usage instructions to document this option.
if (preferences.versions) {
packages/compass-e2e-tests/helpers/compass.ts:478
- The new
getChromiumVersionFromBinaryfunction isn’t covered by any tests; adding unit or integration tests would ensure it correctly parses and converts the Electron version.
async function getChromiumVersionFromBinary(path: string) {
Comment on lines
+478
to
+479
| async function getChromiumVersionFromBinary(path: string) { | ||
| const { stdout } = await execFileIgnoreError(path, ['--versions'], {}); |
There was a problem hiding this comment.
[nitpick] The parameter name path shadows the imported path module; consider renaming it (e.g., to binaryPath) to avoid confusion.
Suggested change
| async function getChromiumVersionFromBinary(path: string) { | |
| const { stdout } = await execFileIgnoreError(path, ['--versions'], {}); | |
| async function getChromiumVersionFromBinary(binaryPath: string) { | |
| const { stdout } = await execFileIgnoreError(binaryPath, ['--versions'], {}); |
gribnoysup
reviewed
Jul 14, 2025
gribnoysup
approved these changes
Jul 14, 2025
Collaborator
gribnoysup
left a comment
gribnoysup
left a comment
There was a problem hiding this comment.
One question / suggestion (that I don't think is that important), otherwise looks good to me, hopefully will help with the smokes!
lerouxb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.